-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(gha): set up CI #4
Conversation
Signed-off-by: Isac Byeonghoon Yoo <[email protected]>
Signed-off-by: Isac Byeonghoon Yoo <[email protected]>
Signed-off-by: Isac Byeonghoon Yoo <[email protected]>
Signed-off-by: Isac Byeonghoon Yoo <[email protected]>
Signed-off-by: Isac Byeonghoon Yoo <[email protected]>
Signed-off-by: Isac Byeonghoon Yoo <[email protected]>
Signed-off-by: Isac Byeonghoon Yoo <[email protected]>
Signed-off-by: Isac Byeonghoon Yoo <[email protected]>
Signed-off-by: Isac Byeonghoon Yoo <[email protected]>
This reverts commit a12f5ac.
Signed-off-by: Isac Byeonghoon Yoo <[email protected]>
This reverts commit 55eb498.
This reverts commit 8142c80.
Signed-off-by: Isac Byeonghoon Yoo <[email protected]>
Signed-off-by: Isac Byeonghoon Yoo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Also agree on dropping support up to Python 3.8.
run: | | ||
pip install -U build | ||
python -m build . | ||
- name: Publish package distributions to PyPI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are we bumping the package version while publishing? Can the version be automatically reflected to sdk version header?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are we bumping the package version while publishing?
Just update variable __version__
of plugbear/__init__.py
. Flit will pick the variable and publish with it.
Can the version be automatically reflected to sdk version header?
Yeap. Because the __version__
is an ordinary python variable, and we use it on header directly.
Signed-off-by: Isac Byeonghoon Yoo <[email protected]>
@thefron I think we should drop Python 3.8. The recent versions of pydantic.BaseModel and Pydantic's dataclass are both not fully compatible with Python 3.8 (related issue). Probably I can handle it using some tweaks, but I do not think it is worth it.